linux-kernel - Re: [PATCH v1 07/17] perf mem-events: Don't leak online CPU map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aS3J06ZnbOvDXYfC@x1>
Date: Mon, 1 Dec 2025 14:01:07 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	Collin Funk <collin.funk1@...il.com>,
	Dmitry Vyukov <dvyukov@...gle.com>, Andi Kleen <ak@...ux.intel.com>,
	Thomas Falcon <thomas.falcon@...el.com>, Leo Yan <leo.yan@....com>,
	Yicong Yang <yangyicong@...ilicon.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	Stephen Brennan <stephen.s.brennan@...cle.com>,
	Haibo Xu <haibo1.xu@...el.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v1 07/17] perf mem-events: Don't leak online CPU map

On Sat, Nov 22, 2025 at 12:19:19AM -0800, Ian Rogers wrote:
> Reference count checking found the online CPU map was being gotten but
> not put. Add in the missing put.

Reviewed-by: Arnaldo Carvalho de Melo <acme@...hat.com>

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/mem-events.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 80b3069427bc..0b49fce251fc 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -303,12 +303,15 @@ int perf_mem_events__record_args(const char **rec_argv, int *argv_nr, char **eve
>  	}
>  
>  	if (cpu_map) {
> -		if (!perf_cpu_map__equal(cpu_map, cpu_map__online())) {
> +		struct perf_cpu_map *online = cpu_map__online();
> +
> +		if (!perf_cpu_map__equal(cpu_map, online)) {
>  			char buf[200];
>  
>  			cpu_map__snprint(cpu_map, buf, sizeof(buf));
>  			pr_warning("Memory events are enabled on a subset of CPUs: %s\n", buf);
>  		}
> +		perf_cpu_map__put(online);
>  		perf_cpu_map__put(cpu_map);
>  	}
>  
> -- 
> 2.52.0.rc2.455.g230fcf2819-goog