linux-kernel - Re: [PATCH] rust: auxiliary: use `pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DEMKK0Z8DWR1.3EBQYP6YO32JA@nvidia.com>
Date: Mon, 01 Dec 2025 12:44:38 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Alexandre Courbot" <acourbot@...dia.com>, "Atharv Dubey"
 <atharvd440@...il.com>, <gregkh@...uxfoundation.org>, <ojeda@...nel.org>,
 <alex.gaynor@...il.com>
Cc: <david.m.ertman@...el.com>, <ira.weiny@...el.com>, <leon@...nel.org>,
 <boqun.feng@...il.com>, <gary@...yguo.net>, <bjorn3_gh@...tonmail.com>,
 <lossin@...nel.org>, <a.hindborg@...nel.org>, <aliceryhl@...gle.com>,
 <tmgross@...ch.edu>, <dakr@...nel.org>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: auxiliary: use `pin_init::zeroed()` for  device
 ID

On Mon Dec 1, 2025 at 12:34 PM JST, Alexandre Courbot wrote:
> On Sat Nov 29, 2025 at 9:47 PM JST, Atharv Dubey wrote:
>> Replace the previous `unsafe { core::mem::zeroed() }` initialization
>> for `bindings::auxillary_device_id` with `pin_init::zeroed()`. This removes
>> the explicit unsafe block and uses the safer pinned zero-initialization
>> helper.
>>
>> Signed-off-by: Atharv Dubey <atharvd440@...il.com>
>> ---
>>  rust/kernel/auxiliary.rs | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
>> index 7a3b0b9c418e..67c5d356d754 100644
>> --- a/rust/kernel/auxiliary.rs
>> +++ b/rust/kernel/auxiliary.rs
>> @@ -108,11 +108,7 @@ pub const fn new(modname: &'static CStr, name: &'static CStr) -> Self {
>>          let name = name.to_bytes_with_nul();
>>          let modname = modname.to_bytes_with_nul();
>>  
>> -        // TODO: Replace with `bindings::auxiliary_device_id::default()` once stabilized for
>> -        // `const`.
>
> I'd still keep this `TODO`, a `Default` implementation is more adequate
> that `Zeroable` here even if they end up doing the same.

... or maybe not, after all if a type implements `Zeroable` this means
that all zeroes is a valid initial value for it. Let's see what others
think about this.