linux-kernel - Re: [PATCH] alpha: don't reference obsolete termio struct for TC* constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871pleyhqc.fsf@gentoo.org>
Date: Mon, 01 Dec 2025 03:59:55 +0000
From: Sam James <sam@...too.org>
To: "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: Richard Henderson <richard.henderson@...aro.org>,  Matt Turner
 <mattst88@...il.com>,  Stian Halseth <stian@....no>,  Magnus Lindholm
 <linmag7@...il.com>,  linux-alpha@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] alpha: don't reference obsolete termio struct for TC*
 constants

"Maciej W. Rozycki" <macro@...am.me.uk> writes:

> On Thu, 2 Oct 2025, Sam James wrote:
>
>> Similar in nature to ab107276607af90b13a5994997e19b7b9731e251. glibc-2.42
>> drops the legacy termio struct, but the ioctls.h header still defines some
>> TC* constants in terms of termio (via sizeof). Hardcode the values instead.
>> 
>> This fixes building Python for example, which falls over like:
>>   ./Modules/termios.c:1119:16: error: invalid application of 'sizeof' to incomplete type 'struct termio'
>> 
>> Link: https://bugs.gentoo.org/961769
>> Link: https://bugs.gentoo.org/962600
>> Co-authored-by: Stian Halseth <stian@....no>
>> Co-authored-by: Magnus Lindholm <linmag7@...il.com>
>> Signed-off-by: Sam James <sam@...too.org>
>
>  FWIW, the documented tag for co-authors is Co-developed-by: and you're 
> supposed to collect corresponding Signed-off-by: tags from each of them 
> too.  Cf. <Documentation/process/submitting-patches.rst> and the examples 
> there.

Thanks, though I'd say I was more being gracious here and that it's not
strictly required to have them here at all.

Anyway, Magnus, I can resend with just my Signed-off-by (and nothing
else) if you like, or can you do that in your tree?

>
>   Maciej