linux-kernel - Re: [PATCH v2] kbuild: fix compilation of dtb specified on command-line without make rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqK5qS--kTudaEM-hBkVo=ck073gskum3puM_fp7nT6BPQ@mail.gmail.com>
Date: Mon, 1 Dec 2025 11:36:42 -0600
From: Rob Herring <robh@...nel.org>
To: Thomas De Schampheleire <thomas.de_schampheleire@...ia.com>
Cc: linux-kbuild@...r.kernel.org, Masahiro Yamada <masahiroy@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nsc@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: fix compilation of dtb specified on
 command-line without make rule

On Wed, Nov 26, 2025 at 4:00 AM Thomas De Schampheleire
<thomas.de_schampheleire@...ia.com> wrote:
>
> Since commit e7e2941300d2 ("kbuild: split device tree build rules into
> scripts/Makefile.dtbs"), it is no longer possible to compile a device tree
> blob that is not specified in a make rule
> like:
>     dtb-$(CONFIG_FOO) += foo.dtb
>
> Before the mentioned commit, one could copy a dts file to e.g.
> arch/arm64/boot/dts/ (or a new subdirectory) and then convert it to a dtb
> file using:
>     make ARCH=arm64 foo.dtb
>
> In this scenario, both 'dtb-y' and 'dtb-' are empty, and the inclusion of
> scripts/Makefile.dtbs relies on 'targets' to contain the MAKECMDGOALS. The
> value of 'targets', however, is only final later in the code.
>
> Move the conditional include of scripts/Makefile.dtbs down to where the
> value of 'targets' is final. Since Makefile.dtbs updates 'always-y' which is
> used as a prerequisite in the build rule, the build rule also needs to move
> down.
>
> Fixes: e7e2941300d2 ("kbuild: split device tree build rules into scripts/Makefile.dtbs")
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@...ia.com>
> ---
> v2: fix 'make dtbs' by moving the 'Build' rule along
>
>  scripts/Makefile.build | 26 ++++++++++++++------------
>  1 file changed, 14 insertions(+), 12 deletions(-)

Acked-by: Rob Herring (Arm) <robh@...nel.org>