linux-kernel - Re: [PATCH] mux: mmio: fix regmap leak on probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5380725e-9f94-4340-9234-986ed21cb07c@ti.com>
Date: Mon, 1 Dec 2025 12:02:09 -0600
From: Andrew Davis <afd@...com>
To: Johan Hovold <johan@...nel.org>, Peter Rosin <peda@...ntia.se>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH] mux: mmio: fix regmap leak on probe failure

On 11/27/25 7:47 AM, Johan Hovold wrote:
> The mmio regmap that may be allocated during probe is never freed.
> 
> Switch to using the device managed allocator so that the regmap is
> released on probe failures (e.g. probe deferral) and on driver unbind.
> 
> Fixes: 61de83fd8256 ("mux: mmio: Do not use syscon helper to build regmap")
> Cc: stable@...r.kernel.org	# 6.16
> Cc: Andrew Davis <afd@...com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---

Acked-by: Andrew Davis <afd@...com>

>   drivers/mux/mmio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
> index 9993ce38a818..5b0171d19d43 100644
> --- a/drivers/mux/mmio.c
> +++ b/drivers/mux/mmio.c
> @@ -58,7 +58,7 @@ static int mux_mmio_probe(struct platform_device *pdev)
>   		if (IS_ERR(base))
>   			regmap = ERR_PTR(-ENODEV);
>   		else
> -			regmap = regmap_init_mmio(dev, base, &mux_mmio_regmap_cfg);
> +			regmap = devm_regmap_init_mmio(dev, base, &mux_mmio_regmap_cfg);
>   		/* Fallback to checking the parent node on "real" errors. */
>   		if (IS_ERR(regmap) && regmap != ERR_PTR(-EPROBE_DEFER)) {
>   			regmap = dev_get_regmap(dev->parent, NULL);