linux-kernel - Re: [PATCH v3 1/9] md: bcache: fix improper use of bi_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFAC6F10-B224-4524-9D8F-506B5312A2E8@coly.li>
Date: Mon, 1 Dec 2025 13:45:24 +0800
From: "Coly Li" <colyli@...as.com>
To: "zhangshida" <starzhangzsd@...il.com>
Cc: <Johannes.Thumshirn@....com>, <hch@...radead.org>, <agruenba@...hat.com>, 
	<ming.lei@...hat.com>, <hsiangkao@...ux.alibaba.com>, 
	<csander@...estorage.com>, <linux-block@...r.kernel.org>, 
	<linux-bcache@...r.kernel.org>, <nvdimm@...ts.linux.dev>, 
	<virtualization@...ts.linux.dev>, <ntfs3@...ts.linux.dev>, 
	<linux-xfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>, 
	<zhangshida@...inos.cn>
Subject: Re: [PATCH v3 1/9] md: bcache: fix improper use of bi_end_io

> 2025年11月29日 17:01，zhangshida <starzhangzsd@...il.com> 写道：
> 
> From: Shida Zhang <zhangshida@...inos.cn>
> 
> Don't call bio->bi_end_io() directly. Use the bio_endio() helper
> function instead, which handles completion more safely and uniformly.
> 
> Suggested-by: Christoph Hellwig <hch@...radead.org>
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> ---
> drivers/md/bcache/request.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index af345dc6fde..82fdea7dea7 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c

[snipped]

The patch is good. Please modify the patch subject to:  bcache: fix improper use of bi_end_io

You may directly send the refined version to linux-bcache mailing list, I will take it.

Thanks.

Coly Li