linux-kernel - Re: [PATCH v1 1/1] args: Fix documentation to reflect the correct numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d334c6fc-1e24-4a8c-87cc-d70a4388bd49@infradead.org>
Date: Mon, 1 Dec 2025 12:16:49 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-kernel@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v1 1/1] args: Fix documentation to reflect the correct
 numbers



On 12/1/25 12:10 PM, Andy Shevchenko wrote:
> The macro uses up to 15 arguments. Reflect this in the top
> level comment.
> 

You made me look!

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> Fixes: d51e783c17ba ("lsm: count the LSMs enabled at compile time")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  include/linux/args.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/args.h b/include/linux/args.h
> index 2e8e65d975c7..0562dc51435e 100644
> --- a/include/linux/args.h
> +++ b/include/linux/args.h
> @@ -6,9 +6,9 @@
>  /*
>   * How do these macros work?
>   *
> - * In __COUNT_ARGS() _0 to _12 are just placeholders from the start
> + * In __COUNT_ARGS() _0 to _15 are just placeholders from the start
>   * in order to make sure _n is positioned over the correct number
> - * from 12 to 0 (depending on X, which is a variadic argument list).
> + * from 15 to 0 (depending on X, which is a variadic argument list).
>   * They serve no purpose other than occupying a position. Since each
>   * macro parameter must have a distinct identifier, those identifiers
>   * are as good as any.

-- 
~Randy