linux-kernel - Re: [PATCH] fat: remove unused parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h5u9vn29.fsf@mail.parknet.co.jp>
Date: Tue, 02 Dec 2025 07:45:18 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Lalit Shankar Chowdhury <lalitshankarch@...il.com>
Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fat: remove unused parameter

Lalit Shankar Chowdhury <lalitshankarch@...il.com> writes:

> Remove unused inode parameter from fat_cache_alloc().
>
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@...il.com>

Looks good.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> ---
>  fs/fat/cache.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 2af424e200b3..4cea26ddc161 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -59,7 +59,7 @@ void fat_cache_destroy(void)
>  	kmem_cache_destroy(fat_cache_cachep);
>  }
>  
> -static inline struct fat_cache *fat_cache_alloc(struct inode *inode)
> +static inline struct fat_cache *fat_cache_alloc(void)
>  {
>  	return kmem_cache_alloc(fat_cache_cachep, GFP_NOFS);
>  }
> @@ -149,7 +149,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
>  			MSDOS_I(inode)->nr_caches++;
>  			spin_unlock(&MSDOS_I(inode)->cache_lru_lock);
>  
> -			tmp = fat_cache_alloc(inode);
> +			tmp = fat_cache_alloc();
>  			if (!tmp) {
>  				spin_lock(&MSDOS_I(inode)->cache_lru_lock);
>  				MSDOS_I(inode)->nr_caches--;

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>