linux-kernel - Re: [PATCH v3] rust: clist: Add support to interface with C linked lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2584CA37-1AE6-4B1B-90B1-8DE4F826E760@collabora.com>
Date: Mon, 1 Dec 2025 20:01:58 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Joel Fernandes <joelagnelf@...dia.com>
Cc: John Hubbard <jhubbard@...dia.com>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 dri-devel@...ts.freedesktop.org,
 nouveau@...ts.freedesktop.org,
 Danilo Krummrich <dakr@...nel.org>,
 Dave Airlie <airlied@...il.com>,
 Alexandre Courbot <acourbot@...dia.com>,
 Alistair Popple <apopple@...dia.com>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 bjorn3_gh@...tonmail.com,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 Timur Tabi <ttabi@...dia.com>,
 Joel Fernandes <joel@...lfernandes.org>,
 Lyude Paul <elle@...thered-steel.dev>,
 Andrea Righi <arighi@...dia.com>,
 Philipp Stanner <phasta@...nel.org>
Subject: Re: [PATCH v3] rust: clist: Add support to interface with C linked
 lists



> On 1 Dec 2025, at 17:06, Joel Fernandes <joelagnelf@...dia.com> wrote:
> 
> 
> 
> On 12/1/2025 2:35 PM, John Hubbard wrote:
>> On 12/1/25 8:51 AM, Daniel Almeida wrote:
>>>> On 29 Nov 2025, at 18:30, Joel Fernandes <joelagnelf@...dia.com> wrote:
>> ...
>>>> +#[repr(transparent)]
>>>> +pub struct ClistHead(Opaque<bindings::list_head>);
>>> 
>>> I still think we should call this CList. IMHO, it does not make sense to have a
>> 
>> I am guessing you meant to place this comment after Clist, rather than here
>> (after ClistHead)? Otherwise I don't know what you are actually suggesting?
>> 
>>> Clist, and a ClistHead (notice the capitalization). CList and CListHead are
>>> easier to read and reason about.
>>> 
>>> Did anyone push back on this?
>> 
>> If you are simply recommending renaming:
>>    Clist     --> CList
>>    ClistHead --> CListHead
>> 
>> ...then I'd say "+1" for that suggestion.
> 
> I am not fond of the suggestion but I don't oppose it either. I honestly don't
> like the triple capitalization with CListHead though. Lets see where all of us
> stand and then take a call on it. Opinions?
> 
> Thanks.

Well, there are three things at play:

C, List, Head

So I think that the CListHead capitalization correctly describes it. IMHO
it’s hard to see “C” and “List” if you spell it
“Clist”, i.e.: it’s easier to read this as a single word and wonder
what’s that for a few seconds.

This is a bit of a nitpick though, so feel free to keep the old spelling if
there is no consensus here.

— Daniel