linux-kernel - Re: [PATCH] KVM: selftests: Fix core dump in rseq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c1860a0-91b0-40fc-acd0-97f04e6b3851@redhat.com>
Date: Tue, 2 Dec 2025 09:16:49 +1000
From: Gavin Shan <gshan@...hat.com>
To: kvmarm@...ts.linux.dev, Sean Christopherson <seanjc@...gle.com>
Cc: kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, pbonzini@...hat.com, shuah@...nel.org,
 seanjc@...gle.com, shan.gavin@...il.com
Subject: Re: [PATCH] KVM: selftests: Fix core dump in rseq_test

Hi Sean,

On 11/24/25 3:04 PM, Gavin Shan wrote:
> In commit 0297cdc12a87 ("KVM: selftests: Add option to rseq test to
> override /dev/cpu_dma_latency"), a 'break' is missed before the option
> 'l' in the argument parsing loop, which leads to an unexpected core
> dump in atoi_paranoid(). It tries to get the latency from non-existent
> argument.
> 
>    host$ ./rseq_test -u
>    Random seed: 0x6b8b4567
>    Segmentation fault (core dumped)
> 
> Add a 'break' before the option 'l' in the argument parsing loop to avoid
> the unexpected core dump.
> 
> Fixes: 0297cdc12a87 ("KVM: selftests: Add option to rseq test to override /dev/cpu_dma_latency")
> Cc: stable@...r.kernel.org # v6.15+
> Signed-off-by: Gavin Shan <gshan@...hat.com>
> ---
>   tools/testing/selftests/kvm/rseq_test.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Could you help to take a look when getting a chance? :)

Thanks,
Gavin

> diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/selftests/kvm/rseq_test.c
> index 1375fca80bcdb..f80ad6b47d16b 100644
> --- a/tools/testing/selftests/kvm/rseq_test.c
> +++ b/tools/testing/selftests/kvm/rseq_test.c
> @@ -215,6 +215,7 @@ int main(int argc, char *argv[])
>   		switch (opt) {
>   		case 'u':
>   			skip_sanity_check = true;
> +			break;
>   		case 'l':
>   			latency = atoi_paranoid(optarg);
>   			break;