Message-ID: <17db5acd-2bb7-45cf-b8e4-b796c49e3baf@amd.com>
Date: Mon, 1 Dec 2025 14:46:54 +0800
From: "Du, Bin" <bin.du@....com>
To: Mario Limonciello <superm1@...nel.org>,
 Sashank Karri <sashank.karri@...il.com>
Cc: Dominic.Antony@....com, Phil.Jawich@....com, anson.tsao@....com,
 benjamin.chan@....com, bryan.odonoghue@...aro.org,
 gjorgji.rosikopulos@....com, hverkuil@...all.nl, king.li@....com,
 laurent.pinchart+renesas@...asonboard.com, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, mario.limonciello@....com, mchehab@...nel.org,
 prabhakar.mahadev-lad.rj@...renesas.com, pratap.nirujogi@....com,
 richard.gong@....com, sakari.ailus@...ux.intel.com, sultan@...neltoast.com,
 "Adam J. Sypniewski" <ajsyp@...tech.net>
Subject: Re: [PATCH v6 0/7] Add AMD ISP4 driver



On 12/1/2025 10:43 AM, Mario Limonciello wrote:
> + "Adam J. Sypniewski" <ajsyp@...tech.net>
> 
> On 11/28/25 9:12 PM, Sashank Karri wrote:
>> Dear Bin,
>>
>> I apologize if this is the wrong place to ask this question and
>> suggest this very slight edit if I understand how ISP4 on the Ryzen AI
>> Max+ 300 series SoCs works.  So the ASUS Rog Flow Z13 2025 also uses
>> the same Strix Halo chips, albeit using the non-PRO series.  On the
>> Windows side, the 13MP sensor, also from Omnivision, requires an AMD
>> Camera Driver, something speciifcally also required by the  5.2 MP
>> camera on the HP ZBook Ultra G1a.  So if both MIPI-capable cameras use
>> the ISP4 technology on the Strix Halo SoC (do they?), this Linux ISP4
>> driver should apply to both cameras, right? If so, shouldn't the ACPI
>> ID for the 13MP sensor also be hardcoded into this code
>>
>>> drm/amd/amdgpu: Declare isp firmware binary file (https:// 
>>> gitlab.freedesktop.org/agd5f/linux/-/ 
>>> commit/35345917bc9f7c86152b270d9d93c220230b667f)
>>
>> Adam J. Sypniewski suggested hardcoding the ACPI ID into the I2C
>> driver here to have the 13MP camera to work (the ASUS specific ACPI ID
>> for the sensor can be found here):
>> https://lore.kernel.org/lkml/aPeqy11m-TxwbzJV@garrus/
> 
> Two things:
> 
> 1) Does this work?  I wouldn't expect it's enough to make everything 
> work 100%.
> 
> 2) AFAICT the Flow Z13 has a USB camera for the front camera, but the 
> rear camera is the one that uses the ISP4.
> 
> So I'm confused by the commit message saying that the front facing 
> camera needs it.  Is that a mistake?
> 
>>
>> I'm entirely new to the Linux kernel mailing list and very unfamiliar
>> with webcam interfaces and how ASUS has chosen to interface the 13 MP
>> sensor with the system, but I can confirm that it does not work yet in
>> the Linux desktop, so I was wondering if the work on this new driver
>> is necessary to get it to work.
>>
>> Sashank
>>
> 
> I think it's going to be a bit more than just an ACPI ID the ISP4 driver 
> though to enable it however.  amdgpu has a list of sensors that it 
> supports (you can see isp_v4_1_1.c for details).  This currently only 
> will recognize and configure the GPIOs for ACPI _HID OMNI5C10.
> 
> For ACPI _HID OMNI13B1 a new entry would be needed there along with the 
> correct GPIO tables that match.  This will wire up the pinctrl-amdisp 
> driver to have the right GPIOs.
> 
> Bin and Pratap can comment more on the feasibility.  But for now I think 
> we should treat this as TODO for after the initial series lands with 
> support for the sensor in the HP ZBook Ultra G1a.

Thanks, Mario. Some more comments, Windows and Linux have different 
architectures. Windows uses ISP and dedicated sensor drivers, while 
Linux places all sensor initialization and control in the ISP firmware, 
functioning like a webcam. Adding new sensors requires updates to both 
the ISP firmware and kernel drivers. For now, only Ov05c10 is supported 
on HP ZBook Ultra G1a.

-- 
Regards,
Bin

Powered by blists - more mailing lists