linux-kernel - Re: Syzbot test for v2 for fs: ocfs2: fix kernel BUG in ocfs2_find_victim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46be391e-da73-4eee-a30b-e404653a76c2@linux.alibaba.com>
Date: Mon, 1 Dec 2025 15:40:36 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: Prithvi Tambewagh <activprithvi@...il.com>, jlbec@...lplan.org,
 mark@...heh.com
Cc: linux-kernel@...r.kernel.org, ocfs2-devel@...ts.linux.dev,
 syzkaller-bugs@...glegroups.com
Subject: Re: Syzbot test for v2 for fs: ocfs2: fix kernel BUG in
 ocfs2_find_victim_chain



On 2025/12/1 15:35, Prithvi Tambewagh wrote:
> #syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 939f15e640f193616691d3bcde0089760e75b0d3
> 
> Signed-off-by: Prithvi Tambewagh <activprithvi@...il.com>
> ---
>  fs/ocfs2/suballoc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index 6ac4dcd54588..f4e4ef08e0f9 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -1992,6 +1992,13 @@ static int ocfs2_claim_suballoc_bits(struct ocfs2_alloc_context *ac,
>  	}
>  
>  	cl = (struct ocfs2_chain_list *) &fe->id2.i_chain;
> +	if (!le16_to_cpu(cl->cl_next_free_rec) ||
> +		le16_to_cpu(cl->cl_next_free_rec) > le16_to_cpu(cl->cl_count)) {
	    ^
Prefer to align here.

BTW, the prefix for patch title can be "ocfs2: " only.

Joseph

> +		status = ocfs2_error(ac->ac_inode->i_sb,
> +				     "Chain allocator dinode %llu has 0 chains\n",
> +				     (unsigned long long)le64_to_cpu(fe->i_blkno));
> +		goto bail;
> +	}
>  
>  	victim = ocfs2_find_victim_chain(cl);
>  	ac->ac_chain = victim;
> 
> base-commit: 939f15e640f193616691d3bcde0089760e75b0d3