linux-kernel - RE: [PATCH iwl-next v2 5/8] ice: update mac,vlan rules when toggling between VEB and VEPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986BC04F434F7D36300D2A8E5DBA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 1 Dec 2025 07:41:47 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Slepecki, Jakub" <jakub.slepecki@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "michal.swiatkowski@...ux.intel.com"
	<michal.swiatkowski@...ux.intel.com>
Subject: RE: [PATCH iwl-next v2 5/8] ice: update mac,vlan rules when toggling
 between VEB and VEPA



> -----Original Message-----
> From: Slepecki, Jakub <jakub.slepecki@...el.com>
> Sent: Friday, November 28, 2025 1:29 PM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; intel-wired-
> lan@...ts.osuosl.org
> Cc: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; michal.swiatkowski@...ux.intel.com
> Subject: Re: [PATCH iwl-next v2 5/8] ice: update mac,vlan rules when
> toggling between VEB and VEPA
> 
> On 2025-11-28 9:36, Loktionov, Aleksandr wrote:
> > One small suggestion: please include prerequisites in the 0/8 cover
> letter (e.g., `iproute2` version and that commands need root
> privileges), so testers don’t miss that.
> 
> Roger that; I plan to use following:
> 
> ---
> To reproduce the issue have a E810 ($pfa) connected to another adapter
> ($pfb), then:
> 
>      # echo 2 >/sys/class/net/$pfa/device/sriov_numvfs
>      # ip l set $pfa vf 0 vlan 4
>      # ip l set $pfa vf 1 vlan 7
>      # ip l set $pfa_vf0 netns $pfa_vf0_netns up
>      # ip l set $pfa_vf1 netns $pfa_vf1_netns up
>      # ip netns exec $pfa_vf0_netns ip a add 10.0.0.1/24 dev $pfa_vf0
>      # ip netns exec $pfa_vf1_netns ip a add 10.0.0.2/24 dev $pfa_vf1
> 
> And for the $pfb:
> 
>      # echo 2 >/sys/class/net/$pfb/device/sriov_numvfs
>      # ip l set $pfb vf 0 trust on spoof off vlan 4
>      # ip l set $pfb vf 1 trust on spoof off vlan 7
>      # ip l add $br type bridge
>      # ip l set $pfb_vf0 master $br up
>      # ip l set $pfb_vf1 master $br up
>      # ip l set $br up
> 
> We expect $pfa_vf0 to be able to reach $pfa_vf1 through the $br on the
> link partner.  Instead, ARP is unable to resolve 10.0.0.2/24.
> ARP request is fine because it's broadcasted and bounces off $br, but
> ARP reply is stuck in the internal switch because the destination MAC
> matches $pfa_vf0 and filter restricts it to loopback.
> 
> In testing I used: ip utility, iproute2-6.1.0, libbpf 1.3.0
> ---
> 
> > Otherwise, the instructions are fine from my side. Please keep my:
> >
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> >
> > Thanks!
> 
> Thanks!


Good day Jakub,
Thanks for sharing the reproduction steps and clarifying the environment details.\
Including prerequisites like iproute2 version and root privileges in the cover letter is a good idea—it helps testers avoid subtle issues.

Reviewed-by stays valid from my side.

Best regards,
Alex