linux-kernel - Re: [PATCH v4 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5292fb7e-9905-4d54-81c9-f415eb68a803@kernel.org>
Date: Mon, 1 Dec 2025 09:36:52 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kumari Pallavi <kumari.pallavi@....qualcomm.com>
Cc: kpallavi@....qualcomm.com, srini@...nel.org, amahesh@....qualcomm.com,
 arnd@...db.de, gregkh@...uxfoundation.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, quic_bkumar@...cinc.com,
 ekansh.gupta@....qualcomm.com, linux-kernel@...r.kernel.org,
 quic_chennak@...cinc.com, dri-devel@...ts.freedesktop.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 jingyi.wang@....qualcomm.com, aiqun.yu@....qualcomm.com,
 ktadakam@....qualcomm.com
Subject: Re: [PATCH v4 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible
 for Kaanapali

On 01/12/2025 09:18, Kumari Pallavi wrote:
>>> Signed-off-by: Kumari Pallavi <kumari.pallavi@....qualcomm.com>
>>> ---
>>>   Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>>> index 3f6199fc9ae6..6c19217d63a6 100644
>>> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>>> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>>> @@ -18,7 +18,10 @@ description: |
>>>   
>>>   properties:
>>>     compatible:
>>> -    const: qcom,fastrpc
>>> +    items:
>>
>> No need to introduce items, wasn't here before. Just enum directly.
>>
> 
> If I use enum directly, the schema will only validate a single 
> string—either "qcom,fastrpc" or "qcom,kaanapali-fastrpc". However, my 
> DTS changes introduce a compatible property with two strings: the 

No, it does not. You still have one item and your claim of any
difference is a proof you did not test it.

> SoC-specific string followed by the generic fallback.
> That’s why I used items in the schema—to allow an array of strings where 
> the first entry is "qcom,kaanapali-fastrpc" and the second is "qcom,fastrpc"




Best regards,
Krzysztof