linux-kernel - Re: [PATCH 4/5] arm64: dts: mediatek: add device tree for Tungsten 510 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29ad8354-231d-470e-a899-cb7c42754c8c@kernel.org>
Date: Mon, 1 Dec 2025 09:53:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gary Bisson <bisson.gary@...il.com>, devicetree@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, angelogioacchino.delregno@...labora.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 matthias.bgg@...il.com
Subject: Re: [PATCH 4/5] arm64: dts: mediatek: add device tree for Tungsten
 510 board

On 01/12/2025 09:41, Gary Bisson wrote:
> +
> +&i2c_mux_lcd_2 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	bridge@2c {
> +		compatible = "ti,sn65dsi84";
> +		reg = <0x2c>;
> +		enable-gpios = <&pio 25 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&dsi0_sn65dsi84_pins>;
> +		status = "okay";

Did you disable it anywhere?


...


> +
> +&spmi {
> +	#address-cells = <1>;
> +	#size-cells = <2>;
> +
> +	mt6315_6: mt6315@6 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

e.g. pmic

> +		compatible = "mediatek,mt6315-regulator";
> +		reg = <0x6 0 0xb>;



Best regards,
Krzysztof