linux-kernel - Re: [PATCH] riscv: pgtable: Cleanup useless VA_USER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <812ce4ef-16cc-6c75-f1b0-ee128dcf45f1@huawei.com>
Date: Mon, 1 Dec 2025 17:27:52 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: <guoren@...nel.org>, <paul.walmsley@...ive.com>, <palmer@...belt.com>,
	<alex@...ti.fr>, <charlie@...osinc.com>
CC: <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: pgtable: Cleanup useless VA_USER_XXX definitions



On 2025/12/1 8:58, guoren@...nel.org wrote:
> From: "Guo Ren (Alibaba DAMO Academy)" <guoren@...nel.org>
> 
> These marcos are not used after commit b5b4287accd7 ("riscv: mm: Use
> hint address in mmap if available"). Cleanup VA_USER_XXX definitions
> in asm/pgtable.h.
> 
> Fixes: b5b4287accd7 ("riscv: mm: Use hint address in mmap if available")
> Signed-off-by: Guo Ren (Alibaba DAMO Academy) <guoren@...nel.org>
> ---
>  arch/riscv/include/asm/pgtable.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 5a08eb5fe99f..30d1ea93dde3 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -124,10 +124,6 @@
>  #ifdef CONFIG_64BIT
>  #include <asm/pgtable-64.h>
>  
> -#define VA_USER_SV39 (UL(1) << (VA_BITS_SV39 - 1))
> -#define VA_USER_SV48 (UL(1) << (VA_BITS_SV48 - 1))
> -#define VA_USER_SV57 (UL(1) << (VA_BITS_SV57 - 1))

Reviewed-by: Jinjie Ruan <ruanjinjie@...wei.com>

> -
>  #define MMAP_VA_BITS_64 ((VA_BITS >= VA_BITS_SV48) ? VA_BITS_SV48 : VA_BITS)
>  #define MMAP_MIN_VA_BITS_64 (VA_BITS_SV39)
>  #define MMAP_VA_BITS (is_compat_task() ? VA_BITS_SV32 : MMAP_VA_BITS_64)