linux-kernel - Re: [PATCH v2 01/11] ntfsplus: in-memory, on-disk structures and headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd-vxzkCJf7D7OOXcVxZn-AbtLFOKAvVqpKEyKyOMsTVdw@mail.gmail.com>
Date: Mon, 1 Dec 2025 19:36:37 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@....de, tytso@....edu, 
	willy@...radead.org, jack@...e.cz, djwong@...nel.org, josef@...icpanda.com, 
	sandeen@...deen.net, rgoldwyn@...e.com, xiang@...nel.org, dsterba@...e.com, 
	pali@...nel.org, ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com, gunho.lee@....com
Subject: Re: [PATCH v2 01/11] ntfsplus: in-memory, on-disk structures and headers

On Mon, Dec 1, 2025 at 4:14 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Thu, Nov 27, 2025 at 01:59:34PM +0900, Namjae Jeon wrote:
> > This adds in-memory, on-disk structures, headers and documentation.
>
> So a lot of this looks very similar to the old prematurely removed
> ntfs driver.  I think reviewing would be a lot simpler if we'd
> find some way to bring that back, allowing to focus on the new
> code.  I'm not sure how easy that would be as the old version
> probably won't build, but a modified revert that doesn't wire it
> up to Kconfig would still significantly reduce the diff.  Especially
> with the rename back to ntfs as suggested.
>
> I can see that you don't want to do the rest as small incremental
> patches, but even a very small number of larger patches ontop of that
> base would help a lot.
Okay, I will try it.
>
> > +iocharset=name               Deprecated option.  Still supported but please use
> > +                     nls=name in the future.  See description for nls=name.
>
> Is there much of a point in bringin this back?
I will update this on the next version.
>
> > + * ntfs_read_mapping_folio - map a folio into accessible memory, reading it if necessary
>
> The very long comment for something that is just a trivial wrapper
> around read_mapping_folio is odd.
These comments are from old ntfs. I will update the content or delete
them if they are unnecessary.
>  Also why does ntrfs need the special
> EINTR handling that other file systems don't?
As Matthew said, it is used to read metadata and need to be handled in
case it is interrupted.
>
> > +/* sizeof()= 40 (0x28) bytes */
>
> You might want to add static_assert() calls instead of the comments
> to enforce this.
Okay, I will add it.
Thanks!
>