linux-kernel - Re: [PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88b63ab9-85bc-4af1-a802-e2e2f332254f@oss.qualcomm.com>
Date: Mon, 1 Dec 2025 12:18:18 +0000
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: Johan Hovold <johan@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
        Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe
 failure



On 12/1/25 9:34 AM, Johan Hovold wrote:
> The original wcd938x driver has a couple of OF node reference leaks
> which have been reproduced in the two later added drivers.
> 
> Johan
> 

Thanks for the patches,

Yes, of_parse_phandle() already gets a node refcount, another refcount
is redundant and will leak.

LGTM

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>

--srini>
> Johan Hovold (3):
>   ASoC: codecs: wcd937x: fix OF node leaks on probe failure
>   ASoC: codecs: wcd938x: fix OF node leaks on probe failure
>   ASoC: codecs: wcd939x: fix OF node leaks on probe failure
> 
>  sound/soc/codecs/wcd937x.c | 4 ++--
>  sound/soc/codecs/wcd938x.c | 3 +--
>  sound/soc/codecs/wcd939x.c | 3 +--
>  3 files changed, 4 insertions(+), 6 deletions(-)
>