linux-kernel - Re: [PATCH v3 04/11] Input: ilitek_ts_i2c: fix warning with gpio controllers that sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <020ff4f6-b7dc-4507-b910-a629fd0a755d@solid-run.com>
Date: Mon, 1 Dec 2025 12:38:53 +0000
From: Josua Mayer <josua@...id-run.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Neil
 Armstrong <neil.armstrong@...aro.org>, Jessica Zhang
	<jessica.zhang@....qualcomm.com>, David Airlie <airlied@...il.com>, Simona
 Vetter <simona@...ll.ch>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Laurent Pinchart
	<laurent.pinchart@...asonboard.com>, Lad Prabhakar
	<prabhakar.mahadev-lad.rj@...renesas.com>, Thierry Reding
	<thierry.reding@...il.com>, Jon Nettleton <jon@...id-run.com>, Mikhail Anikin
	<mikhail.anikin@...id-run.com>, Yazan Shhady <yazan.shhady@...id-run.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 04/11] Input: ilitek_ts_i2c: fix warning with gpio
 controllers that sleep

Am 18.11.25 um 20:22 schrieb Dmitry Torokhov:
> Hi Josua,
>
> On Mon, Nov 17, 2025 at 01:28:46PM +0100, Josua Mayer wrote:
>> The ilitek touchscreen driver uses the non-sleeping gpiod_set_value
>> function for reset.
>>
>> Switch to using gpiod_set_value_cansleep() when controlling reset_gpio to
>> support GPIO providers that may sleep, such as I2C GPIO expanders.
>>
>> This fixes noisy complaints in kernel log for gpio providers that do
>> sleep.
>>
>> Signed-off-by: Josua Mayer <josua@...id-run.com>
>> ---
>>  drivers/input/touchscreen/ilitek_ts_i2c.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c
>> index 0dd632724a003..8c5a54b336816 100644
>> --- a/drivers/input/touchscreen/ilitek_ts_i2c.c
>> +++ b/drivers/input/touchscreen/ilitek_ts_i2c.c
>> @@ -396,9 +396,9 @@ static const struct ilitek_protocol_map ptl_func_map[] = {
>>  static void ilitek_reset(struct ilitek_ts_data *ts, int delay)
>>  {
>>  	if (ts->reset_gpio) {
>> -		gpiod_set_value(ts->reset_gpio, 1);
>> +		gpiod_set_value_cansleep(ts->reset_gpio, 1);
>>  		mdelay(10);
> This (and below) should be usleep_range/msleep/fsleep.

True ....

So I will change it since I am areadly changing the code next to it.

>
>> -		gpiod_set_value(ts->reset_gpio, 0);
>> +		gpiod_set_value_cansleep(ts->reset_gpio, 0);
>>  		mdelay(delay);
>>  	}
>>  }
>>
> Thanks.
>