linux-kernel - Re: [PATCH v3 1/4] scsi: sd: reject invalid pr_read_keys() num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b32a7120-d959-40ba-944f-ef9a758d2d7b@suse.de>
Date: Tue, 2 Dec 2025 16:40:21 +0100
From: Hannes Reinecke <hare@...e.de>
To: Stefan Hajnoczi <stefanha@...hat.com>, linux-block@...r.kernel.org
Cc: Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
 linux-scsi@...r.kernel.org,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
 Sagi Grimberg <sagi@...mberg.me>, Mike Christie
 <michael.christie@...cle.com>, Krzysztof Kozlowski <krzk@...nel.org>,
 linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v3 1/4] scsi: sd: reject invalid pr_read_keys() num_keys
 values

On 12/1/25 22:43, Stefan Hajnoczi wrote:
> The pr_read_keys() interface has a u32 num_keys parameter. The SCSI
> PERSISTENT RESERVE IN command has a maximum READ KEYS service action
> size of 65536 bytes. Reject num_keys values that are too large to fit
> into the SCSI command.
> 
> This will become important when pr_read_keys() is exposed to untrusted
> userspace via an <linux/pr.h> ioctl.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> ---
>   drivers/scsi/sd.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich