linux-kernel - Re: [PATCH] scsi: ufs: core: Fix link error when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <391c97e5201d73438ec506b22c4724285d676697.camel@iokpp.de>
Date: Tue, 02 Dec 2025 16:57:41 +0100
From: Bean Huo <beanhuo@...pp.de>
To: Arnd Bergmann <arnd@...db.de>, Jens Wiklander <jens.wiklander@...aro.org>
Cc: Bart Van Assche <bvanassche@....org>, "Martin K. Petersen"
	 <martin.petersen@...cle.com>, avri.altman@...disk.com, Alim Akhtar
	 <alim.akhtar@...sung.com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, 
	can.guo@....qualcomm.com, Bean Huo <beanhuo@...ron.com>, 
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, kernel test robot
	 <lkp@...el.com>, Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] scsi: ufs: core: Fix link error when CONFIG_RPMB=m

On Tue, 2025-12-02 at 16:47 +0100, Arnd Bergmann wrote:
> > > Any module that links against exported RPMB symbols should have
> > > the 'depends on RPMB || !RPMB' line to enable linking correctly.
> > > The RPMB implementation in drivers/misc on the other hand has no
> > > link-time dependency I can see, and enabling it without one of
> > > the other symbols simply means that there is a module that does
> > > nothing.
> > 
> > I have added this option in my previous email, can you add which one you
> > prefer.
> 
> You suggested:
>  "1. Make RPMB not directly depend on SCSI_UFSHCD in Kconfig then,
>    Use "depends on RPMB || !RPMB" in SCSI_UFSHCD (like MMC does)"
> 
> but I think we should go a step further and remove the
> 'depends on MMC' as well for consistency. Otherwise you create
> a dependency chain that makes it impossible to have UFSHCD
> built-in if MMC is a loadable module.
> 
>     Arnd

Thanks, Just sent a new patch and CC you, please check.


Hi Martin, Bart, and Jens,

Following our discussion and Arnd's suggestion, I've submitted a new patch that
takes a different approach to fix the RPMB link error.

Martin, the new patch should handle your modular build configuration correctly
while fixing the reported link error.

Thanks for all the feedback.

Best regards,
Bean