linux-kernel - Re: [PATCH 2/3] drm/gem-shmem: revert the 8-byte alignment constraint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb4d948f-c09d-46dd-9f76-a7c5df6091b8@suse.de>
Date: Tue, 2 Dec 2025 18:03:28 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Ludovic Desroches <ludovic.desroches@...rochip.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drm/gem-shmem: revert the 8-byte alignment constraint



Am 26.11.25 um 15:44 schrieb Ludovic Desroches:
> Using drm_mode_size_dumb() to compute the size of dumb buffers introduced
> an 8-byte alignment constraint on the pitch that wasn’t present before.
> Let’s remove this constraint, which isn’t necessarily required and may
> cause buffers to be allocated larger than needed.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@...rochip.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Fixes: 4977dcecb931 ("drm/gem-shmem: Compute dumb-buffer sizes with 
drm_mode_size_dumb()")


> ---
>   drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index dc94a27710e5f48839a5d2e9e9ea5152ff22e438..93b9cff89080f94e5d6e4663ef642b4c36e93c71 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -559,7 +559,7 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev,
>   {
>   	int ret;
>   
> -	ret = drm_mode_size_dumb(dev, args, SZ_8, 0);
> +	ret = drm_mode_size_dumb(dev, args, 0, 0);
>   	if (ret)
>   		return ret;
>   
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)