linux-kernel - Re: [PATCH net-next v7 4/9] net: let pp memory provider to specify rx buf len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251202110431.376dc793@kernel.org>
Date: Tue, 2 Dec 2025 11:04:31 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan
 Corbet <corbet@....net>, Michael Chan <michael.chan@...adcom.com>, Pavan
 Chebbi <pavan.chebbi@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John
 Fastabend <john.fastabend@...il.com>, Ilias Apalodimas
 <ilias.apalodimas@...aro.org>, Shuah Khan <shuah@...nel.org>, Mina Almasry
 <almasrymina@...gle.com>, Stanislav Fomichev <sdf@...ichev.me>, Yue Haibing
 <yuehaibing@...wei.com>, David Wei <dw@...idwei.uk>, Haiyue Wang
 <haiyuewa@....com>, Jens Axboe <axboe@...nel.dk>, Joe Damato
 <jdamato@...tly.com>, Simon Horman <horms@...nel.org>, Vishwanath Seshagiri
 <vishs@...com>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 io-uring@...r.kernel.org, dtatulea@...dia.com
Subject: Re: [PATCH net-next v7 4/9] net: let pp memory provider to specify
 rx buf len

On Sun, 30 Nov 2025 23:35:19 +0000 Pavel Begunkov wrote:
> +enum {
> +	/* queue restart support custom rx buffer sizes */
> +	NDO_QUEUE_RX_BUF_SIZE		= 0x1,

If you have to respin -- let's drop the NDO from this define.
To suggest something specific - QCFG_ is a better prefix?
IDK why we ended up with ndo_ prefix on the queue ops..

Also RX_PAGE_SIZE is a better name for the fields? RX_BUF_SIZE
is easy to confuse with RX_BUF_LEN which we are no longer trying
to modify.