linux-kernel - Re: [PATCH net V2] r8169: fix RTL8117 Wake-on-Lan in DASH mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82984a56-5bea-48ef-98ed-20d83377808e@gmail.com>
Date: Tue, 2 Dec 2025 20:10:59 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: René Rebe <rene@...ctco.de>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: nic_swsd@...ltek.com, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 françois romieu <romieu@...zoreil.com>
Subject: Re: [PATCH net V2] r8169: fix RTL8117 Wake-on-Lan in DASH mode

On 12/2/2025 7:41 PM, René Rebe wrote:
> Wake-on-Lan does currently not work for r8169 in DASH mode, e.g. the
> ASUS Pro WS X570-ACE with RTL8168fp/RTL8117.
> 
> Fix by not returning early in rtl_prepare_power_down when dash_enabled.
> While this fixes WoL, it still kills the OOB RTL8117 remote management
> BMC connection. Fix by not calling rtl8168_driver_stop if WoL is enabled.
> 
> Fixes: 065c27c184d6 ("r8169: phy power ops")
> Signed-off-by: René Rebe <rene@...ctco.de>
> Cc: stable@...r.kernel.org
> ---
> V2; DASH WoL fix only
> Tested on ASUS Pro WS X570-ACE with RTL8168fp/RTL8117 running T2/Linux.
> ---

Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>