| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202512030247.AllzCFdb-lkp@intel.com>
Date: Wed, 3 Dec 2025 03:20:16 +0800
From: kernel test robot <lkp@...el.com>
To: Po-Wen Kao <powenkao@...gle.com>
Cc: oe-kbuild-all@...ts.linux.dev, Brian Kao <powenkao@...gle.com>,
"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
"open list:SCSI SUBSYSTEM" <linux-scsi@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] scsi: core: Fix error handler encryption support
Hi Po-Wen,
kernel test robot noticed the following build errors:
[auto build test ERROR on jejb-scsi/for-next]
[also build test ERROR on mkp-scsi/for-next linus/master v6.18 next-20251202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Po-Wen-Kao/scsi-core-Fix-error-handler-encryption-support/20251202-091809
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20251202011529.73738-1-powenkao%40google.com
patch subject: [PATCH 1/1] scsi: core: Fix error handler encryption support
config: i386-randconfig-013-20251202 (https://download.01.org/0day-ci/archive/20251203/202512030247.AllzCFdb-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251203/202512030247.AllzCFdb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512030247.AllzCFdb-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/scsi/scsi_error.c: In function 'scsi_eh_prep_cmnd':
>> drivers/scsi/scsi_error.c:1122:35: error: 'struct request' has no member named 'crypt_keyslot'
1122 | ses->rq_crypt_keyslot = rq->crypt_keyslot;
| ^~
>> drivers/scsi/scsi_error.c:1123:31: error: 'struct request' has no member named 'crypt_ctx'
1123 | ses->rq_crypt_ctx = rq->crypt_ctx;
| ^~
drivers/scsi/scsi_error.c:1125:11: error: 'struct request' has no member named 'crypt_keyslot'
1125 | rq->crypt_keyslot = NULL;
| ^~
drivers/scsi/scsi_error.c:1126:11: error: 'struct request' has no member named 'crypt_ctx'
1126 | rq->crypt_ctx = NULL;
| ^~
drivers/scsi/scsi_error.c: In function 'scsi_eh_restore_cmnd':
drivers/scsi/scsi_error.c:1160:11: error: 'struct request' has no member named 'crypt_keyslot'
1160 | rq->crypt_keyslot = ses->rq_crypt_keyslot;
| ^~
drivers/scsi/scsi_error.c:1161:11: error: 'struct request' has no member named 'crypt_ctx'
1161 | rq->crypt_ctx = ses->rq_crypt_ctx;
| ^~
vim +1122 drivers/scsi/scsi_error.c
1047
1048 /**
1049 * scsi_eh_prep_cmnd - Save a scsi command info as part of error recovery
1050 * @scmd: SCSI command structure to hijack
1051 * @ses: structure to save restore information
1052 * @cmnd: CDB to send. Can be NULL if no new cmnd is needed
1053 * @cmnd_size: size in bytes of @cmnd (must be <= MAX_COMMAND_SIZE)
1054 * @sense_bytes: size of sense data to copy. or 0 (if != 0 @cmnd is ignored)
1055 *
1056 * This function is used to save a scsi command information before re-execution
1057 * as part of the error recovery process. If @sense_bytes is 0 the command
1058 * sent must be one that does not transfer any data. If @sense_bytes != 0
1059 * @cmnd is ignored and this functions sets up a REQUEST_SENSE command
1060 * and cmnd buffers to read @sense_bytes into @scmd->sense_buffer.
1061 */
1062 void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses,
1063 unsigned char *cmnd, int cmnd_size, unsigned sense_bytes)
1064 {
1065 struct scsi_device *sdev = scmd->device;
1066 struct request *rq = scsi_cmd_to_rq(scmd);
1067
1068 /*
1069 * We need saved copies of a number of fields - this is because
1070 * error handling may need to overwrite these with different values
1071 * to run different commands, and once error handling is complete,
1072 * we will need to restore these values prior to running the actual
1073 * command.
1074 */
1075 ses->cmd_len = scmd->cmd_len;
1076 ses->data_direction = scmd->sc_data_direction;
1077 ses->sdb = scmd->sdb;
1078 ses->result = scmd->result;
1079 ses->resid_len = scmd->resid_len;
1080 ses->underflow = scmd->underflow;
1081 ses->prot_op = scmd->prot_op;
1082 ses->eh_eflags = scmd->eh_eflags;
1083
1084 scmd->prot_op = SCSI_PROT_NORMAL;
1085 scmd->eh_eflags = 0;
1086 memcpy(ses->cmnd, scmd->cmnd, sizeof(ses->cmnd));
1087 memset(scmd->cmnd, 0, sizeof(scmd->cmnd));
1088 memset(&scmd->sdb, 0, sizeof(scmd->sdb));
1089 scmd->result = 0;
1090 scmd->resid_len = 0;
1091
1092 if (sense_bytes) {
1093 scmd->sdb.length = min_t(unsigned, SCSI_SENSE_BUFFERSIZE,
1094 sense_bytes);
1095 sg_init_one(&ses->sense_sgl, scmd->sense_buffer,
1096 scmd->sdb.length);
1097 scmd->sdb.table.sgl = &ses->sense_sgl;
1098 scmd->sc_data_direction = DMA_FROM_DEVICE;
1099 scmd->sdb.table.nents = scmd->sdb.table.orig_nents = 1;
1100 scmd->cmnd[0] = REQUEST_SENSE;
1101 scmd->cmnd[4] = scmd->sdb.length;
1102 scmd->cmd_len = COMMAND_SIZE(scmd->cmnd[0]);
1103 } else {
1104 scmd->sc_data_direction = DMA_NONE;
1105 if (cmnd) {
1106 BUG_ON(cmnd_size > sizeof(scmd->cmnd));
1107 memcpy(scmd->cmnd, cmnd, cmnd_size);
1108 scmd->cmd_len = COMMAND_SIZE(scmd->cmnd[0]);
1109 }
1110 }
1111
1112 scmd->underflow = 0;
1113
1114 if (sdev->scsi_level <= SCSI_2 && sdev->scsi_level != SCSI_UNKNOWN)
1115 scmd->cmnd[1] = (scmd->cmnd[1] & 0x1f) |
1116 (sdev->lun << 5 & 0xe0);
1117
1118 /*
1119 * Encryption must be disabled for the commands submitted by the error handler.
1120 * Hence, clear the encryption context information.
1121 */
> 1122 ses->rq_crypt_keyslot = rq->crypt_keyslot;
> 1123 ses->rq_crypt_ctx = rq->crypt_ctx;
1124
1125 rq->crypt_keyslot = NULL;
1126 rq->crypt_ctx = NULL;
1127
1128 /*
1129 * Zero the sense buffer. The scsi spec mandates that any
1130 * untransferred sense data should be interpreted as being zero.
1131 */
1132 memset(scmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
1133 }
1134 EXPORT_SYMBOL(scsi_eh_prep_cmnd);
1135
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists