linux-kernel - Re: [PATCH v3] mcb: Add missing modpost build support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251202203421.GB1959956@ax162>
Date: Tue, 2 Dec 2025 13:34:21 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
Cc: andy@...nel.org, krzk@...nel.org, linus.walleij@...aro.org,
	nsc@...nel.org, gregkh@...uxfoundation.org, bleung@...omium.org,
	heikki.krogerus@...ux.intel.com, abhishekpandit@...omium.org,
	masahiroy@...nel.org, legion@...nel.org, hughd@...gle.com,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
Subject: Re: [PATCH v3] mcb: Add missing modpost build support

On Tue, Dec 02, 2025 at 09:42:00AM +0100, Jose Javier Rodriguez Barbarin wrote:
> mcb bus is not prepared to autoload client drivers with the data defined on
> the drivers' MODULE_DEVICE_TABLE. modpost cannot access to mcb_table_id
> inside MODULE_DEVICE_TABLE so the data declared inside is ignored.
> 
> Add modpost build support for accessing to the mcb_table_id coded on device
> drivers' MODULE_DEVICE_TABLE.
> 
> Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus")
> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> ---

Acked-by: Nathan Chancellor <nathan@...nel.org>

We should be able to get this to Linus by 6.19-rc1.

>  scripts/mod/devicetable-offsets.c | 3 +++
>  scripts/mod/file2alias.c          | 9 +++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable-offsets.c
> index d3d00e85edf7..0470ba7c796d 100644
> --- a/scripts/mod/devicetable-offsets.c
> +++ b/scripts/mod/devicetable-offsets.c
> @@ -198,6 +198,9 @@ int main(void)
>  	DEVID(cpu_feature);
>  	DEVID_FIELD(cpu_feature, feature);
>  
> +	DEVID(mcb_device_id);
> +	DEVID_FIELD(mcb_device_id, device);
> +
>  	DEVID(mei_cl_device_id);
>  	DEVID_FIELD(mei_cl_device_id, name);
>  	DEVID_FIELD(mei_cl_device_id, uuid);
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index b3333560b95e..4e99393a35f1 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -1110,6 +1110,14 @@ static void do_cpu_entry(struct module *mod, void *symval)
>  	module_alias_printf(mod, false, "cpu:type:*:feature:*%04X*", feature);
>  }
>  
> +/* Looks like: mcb:16zN */
> +static void do_mcb_entry(struct module *mod, void *symval)
> +{
> +	DEF_FIELD(symval, mcb_device_id, device);
> +
> +	module_alias_printf(mod, false, "mcb:16z%03d", device);
> +}
> +
>  /* Looks like: mei:S:uuid:N:* */
>  static void do_mei_entry(struct module *mod, void *symval)
>  {
> @@ -1444,6 +1452,7 @@ static const struct devtable devtable[] = {
>  	{"mipscdmm", SIZE_mips_cdmm_device_id, do_mips_cdmm_entry},
>  	{"x86cpu", SIZE_x86_cpu_id, do_x86cpu_entry},
>  	{"cpu", SIZE_cpu_feature, do_cpu_entry},
> +	{"mcb", SIZE_mcb_device_id, do_mcb_entry},
>  	{"mei", SIZE_mei_cl_device_id, do_mei_entry},
>  	{"rapidio", SIZE_rio_device_id, do_rio_entry},
>  	{"ulpi", SIZE_ulpi_device_id, do_ulpi_entry},
> -- 
> 2.51.1