linux-kernel - Re: [PATCH 03/21] PCI: Require driver_override for incoming Live Update preserved devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACePvbXQXVgD2YnEB+_6AWzPrrmwjWcPQxZkraMGenThd2NgcQ@mail.gmail.com>
Date: Wed, 3 Dec 2025 01:24:43 +0400
From: Chris Li <chrisl@...nel.org>
To: David Matlack <dmatlack@...gle.com>
Cc: Alex Williamson <alex@...zbot.org>, Adithya Jayachandran <ajayachandra@...dia.com>, 
	Alex Mastro <amastro@...com>, Alistair Popple <apopple@...dia.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	David Rientjes <rientjes@...gle.com>, Jacob Pan <jacob.pan@...ux.microsoft.com>, 
	Jason Gunthorpe <jgg@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>, Josh Hilke <jrhilke@...gle.com>, 
	Kevin Tian <kevin.tian@...el.com>, kvm@...r.kernel.org, 
	Leon Romanovsky <leonro@...dia.com>, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-pci@...r.kernel.org, 
	Lukas Wunner <lukas@...ner.de>, Mike Rapoport <rppt@...nel.org>, Parav Pandit <parav@...dia.com>, 
	Pasha Tatashin <pasha.tatashin@...een.com>, Philipp Stanner <pstanner@...hat.com>, 
	Pratyush Yadav <pratyush@...nel.org>, Saeed Mahameed <saeedm@...dia.com>, 
	Samiullah Khawaja <skhawaja@...gle.com>, Shuah Khan <shuah@...nel.org>, 
	Tomita Moeko <tomitamoeko@...il.com>, Vipin Sharma <vipinsh@...gle.com>, William Tu <witu@...dia.com>, 
	Yi Liu <yi.l.liu@...el.com>, Yunxiang Li <Yunxiang.Li@....com>, 
	Zhu Yanjun <yanjun.zhu@...ux.dev>
Subject: Re: [PATCH 03/21] PCI: Require driver_override for incoming Live
 Update preserved devices

On Wed, Dec 3, 2025 at 1:16 AM David Matlack <dmatlack@...gle.com> wrote:
>
> On 2025-11-26 07:35 PM, David Matlack wrote:
> > Require driver_override to be set to bind an incoming Live Update
> > preserved device to a driver. Auto-probing could lead to the device
> > being bound to a different driver than what was bound to the device
> > prior to Live Update.
> >
> > Delegate binding preserved devices to the right driver to userspace by
> > requiring driver_override to be set on the device.
> >
> > This restriction is relaxed once a driver calls
> > pci_liveupdate_incoming_finish().
> >
> > Signed-off-by: David Matlack <dmatlack@...gle.com>
>
> After some offline discussion with Jason and Pasha, I will drop this
> patch from the next version to avoid hard-coding a policy in the kernel.
>
> Instead, for the time being, it will be the user's responsibility to
> only preserve devices that do not have any built-in drivers that will
> bind to the device during boot following a Live Update.

Ack, that certainly can simplify the PCI kernel side of the code, the
kernel doesn't need to deal with PCI driver binding.

Chris