linux-kernel - Re: [RFC PATCH v1 1/1] ACPI: PM: s2idle: Add lps0_screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35f69c12-ecd4-4b21-bfb0-53bf57f0febf@collabora.com>
Date: Wed, 3 Dec 2025 01:35:24 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: "Mario Limonciello (AMD) (kernel.org)" <superm1@...nel.org>,
 Antheas Kapenekakis <lkml@...heas.dev>,
 Lennart Poettering <lennart@...ttering.net>,
 Daniel Stone <daniels@...labora.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
 Robert Beckett <bob.beckett@...labora.com>, linux-acpi@...r.kernel.org,
 kernel@...labora.com, linux-kernel@...r.kernel.org,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Xaver Hugl <xaver.hugl@...il.com>, Richard Hughes <richard@...hsie.com>,
 William Jon McCann <mccann@....edu>, "Jaap A . Haitsma" <jaap@...tsma.org>,
 Benjamin Canou <bookeldor@...il.com>, Bastien Nocera <hadess@...ess.net>
Subject: Re: [RFC PATCH v1 1/1] ACPI: PM: s2idle: Add lps0_screen_off sysfs
 interface

On 12/3/25 00:25, Mario Limonciello (AMD) (kernel.org) wrote:
>> An inhibitor process in logind can handle this gracefully very simply.
>> Involving the DRM subsystem just adds a lot of complexity and it is
>> not clear what the benefit would be. There are no known devices that
>> hook DRM components into that DSM.
>>
>>> By doing it this way userspace still has control, but it's not
>>> mandatory for userspace to be changed.
>>
>> On that note, the screen off calls/userspace implementations are
>> optional under both patch series. If userspace is not aware of them,
>> they are still called by the kernel when suspending.
> 
> With the proposal I mentioned you can get the LPS0 _DSM called on a
> handheld when the screen gets called without changing userspace.
> 
>>
>> Current userland also duplicates the functionality of the screen off
>> call, which is primarily turning off the keyboard backlight. So along
>> implementing this call, userspace software like powerdevil/upower
>> needs to be tweaked to avoid doing that if the screen off state is
>> available.
> 
> Sure Any hooking for turning off LEDs manually based off the screen off
> _DSM is totally feasible.

It's not that trivial to add screen on/off hooks to DRM, there is no one
central place for that from what I can tell. I'm seeing variant with DRM
hooks as unnecessary complexity that doesn't solve any practical problem.

A week ago in a private conversation, Daniel Stone gave an example of
laptop's lid-close handling that is done purely in userspace.
Technically, kernel could have DRM hooks for that too, but it doesn't.

Userspace would need to be taught about new power modes in any case.
Addition of DRM hooks should require a well-defined justification, which
is currently absent.

-- 
Best regards,
Dmitry