[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ1PR11MB6083CB1AE9572E62175DAFB9FCD8A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Tue, 2 Dec 2025 23:22:12 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Chatre, Reinette" <reinette.chatre@...el.com>
CC: Fenghua Yu <fenghuay@...dia.com>, "Wieczor-Retman, Maciej"
<maciej.wieczor-retman@...el.com>, Peter Newman <peternewman@...gle.com>,
James Morse <james.morse@....com>, Babu Moger <babu.moger@....com>, "Drew
Fustini" <dfustini@...libre.com>, Dave Martin <Dave.Martin@....com>, "Chen,
Yu C" <yu.c.chen@...el.com>, "x86@...nel.org" <x86@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: [PATCH v14 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when
reading counters
> Thank you. On a high level this looks good to me. I am concerned about the architecture
> "SNC" term creeping deeper into fs code when it (the fs) aims to generalize it as
> "summing domains". Mentioning SNC in the comment may be useful though since it
> helps to understand what is going on by being specific.
> As a nit could the user space message not refer to SNC though? How about something like:
> "Summing domains using assignable counters is not supported."
That looks good. I'll use that.
Thanks
-Tony
Powered by blists - more mailing lists