linux-kernel - Re: [PATCH v4] tty: tty_port: add workqueue to flip tty buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aS58X-1-Izo237HY@slm.duckdns.org>
Date: Mon, 1 Dec 2025 19:42:55 -1000
From: Tejun Heo <tj@...nel.org>
To: Xin Zhao <jackzxcui1989@....com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, hch@...radead.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v4] tty: tty_port: add workqueue to flip tty buffer

Hello,

On Sat, Nov 29, 2025 at 02:10:48AM +0800, Xin Zhao wrote:
> +	if (!(driver->flags & TTY_DRIVER_CUSTOM_WORKQUEUE)) {
> +		driver->flip_wq = alloc_workqueue("%s-flip-wq",
> +						WQ_UNBOUND | WQ_SYSFS,
> +						0, driver->name);
> +		if (!driver->flip_wq) {
> +			error = -ENOMEM;
> +			goto err_unreg_char;
> +		}
> +		for (i = 0; i < driver->num; i++) {
> +			if (driver->ports[i] && !driver->ports[i]->buf.flip_wq)
> +				tty_port_link_driver_wq(driver->ports[i], driver);
> +		}
> +	}

Maybe it's just me not understanding the requirement but does this need to
be this complicated? It was just using system_unbound_wq before. Can we
start with something very simple - ie. one custom workqueue which is shared
across devices? Wouldn't that work?

Thanks.

-- 
tejun