linux-kernel - Re: [PATCH v6 0/9] cifs: Miscellaneous prep patches for rewrite of I/O layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1530645.1764659728@warthog.procyon.org.uk>
Date: Tue, 02 Dec 2025 07:15:28 +0000
From: David Howells <dhowells@...hat.com>
To: Steve French <smfrench@...il.com>
Cc: dhowells@...hat.com, Steve French <sfrench@...ba.org>,
    Paulo Alcantara <pc@...guebit.org>,
    Shyam Prasad N <sprasad@...rosoft.com>,
    Stefan Metzmacher <metze@...ba.org>, Tom Talpey <tom@...pey.com>,
    linux-cifs@...r.kernel.org, netfs@...ts.linux.dev,
    linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/9] cifs: Miscellaneous prep patches for rewrite of I/O layer

Steve French <smfrench@...il.com> wrote:

> The first seven (of the nine you sent recently) applied ok to
> ksmbd-for-next and I can do some testing on them, as we await more
> review and testing of the patches but patch 8 caused a few checkpatch
> warnings (and patch 9 depends on it).  Do you want to clean it up?
>
> 
> ./scripts/checkpatch.pl 9/0008-cifs-Add-a-tracepoint-to-log-EIO-errors.patch
> ERROR: trailing whitespace
> #440: FILE: fs/smb/client/cifssmb.c:1379:
> +^Idefault: $

I can clean this one up.

> ERROR: Macros with complex values should be enclosed in parentheses
> #2069: FILE: fs/smb/client/trace.h:23:
> +#define smb_eio_traces \
> + EM(smb_eio_trace_compress_copy, "compress_copy") \
> + EM(smb_eio_trace_copychunk_inv_rsp, "copychunk_inv_rsp") \
> ...

In this case, checkpatch is wrong.  This cannot be enclosed in parentheses as
it will then fail to compile as this is used to generate an enum.  If you
compare it to other trace headers (including your own trace.h, you'll see this
sort of construct in a number of places).

David