linux-kernel - Re: [PATCH] usb: linux/usb.h: Correct the description of the usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025120247-gong-ranger-619c@gregkh>
Date: Tue, 2 Dec 2025 10:00:52 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Yi Cong <cong.yi@...ux.dev>
Cc: stern@...land.harvard.edu, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, yicong@...inos.cn
Subject: Re: [PATCH] usb: linux/usb.h: Correct the description of the
 usb_device_driver member

On Tue, Dec 02, 2025 at 02:59:17PM +0800, Yi Cong wrote:
> On Mon, 1 Dec 2025 10:14:04 -0500, Alan Stern <stern@...land.harvard.edu> wrote:
> >
> > On Mon, Dec 01, 2025 at 04:53:09PM +0800, Yi Cong wrote:
> > > From: Yi Cong <yicong@...inos.cn>
> > >
> > > In the current kernel USB device driver code, only the name field is
> > > required to be provided; all other fields are optional.
> > > Use the command grep -rnw "struct usb_device_driver" to inspect
> > > how specific drivers are declared.
> >
> > That last sentence should not be part of the patch description; it
> > doesn't explain the patch's purpose or what the patch does.  (It's not
> > even correct, because the grep output doesn't show how the specific
> > drivers are declared.  It mainly shows the filenames and line numbers
> > where the declarations start.)
> >
> 
> Thank you for the reply!
> Do I need to update the commit message and send a new version of the patch?

Yes please.