linux-kernel - Re: [GIT PULL 17/17 for v6.19] vfs fd prepare minimal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgir86nTfX8SG05QhTtV-Vghkk-q6RMeiBUb80hSF2+Lg@mail.gmail.com>
Date: Mon, 1 Dec 2025 17:35:39 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Christian Brauner <brauner@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL 17/17 for v6.19] vfs fd prepare minimal

On Fri, 28 Nov 2025 at 08:51, Christian Brauner <brauner@...nel.org> wrote:
>
> This is an alternative pull request for the FD_{ADD,PREPARE}() work containing
> only parts of the conversion.

Ok, I'm nto super happy with how thsi all looks, partly because
there's been a lot of conflicts.  I don't t hink this was well done,
with multiple different areas getting cleaned up in the same release.

I considered leaving some stuff entirely for the next go-around, but
I've taken it all, although I only took this smaller version of the
FD_ADD().

Not because I think anything was particularly bad, but simply because
I feel it was too much churn for one release. This is all old code
that didn't need to be changed all at once.

Please don't do this again. We're not in that kind of a hurry, and
hurried cleanups aren't great.

Also, I don't love your mqueue merge resolution with the cast to
create the path argument to dentry_open(). So I did that differently.

That said, I don't love mine *either*. It all feels a bit hacky. I get
the feeling that maybe the mqueue case should just have used
FD_PREPARE() / fd_publish() after all.

Anyway, please check that I didn't miss anything. It is entirely possible I did.

             Linus