linux-kernel - Re: linux-next: Tree for Nov 28 (drivers/pci/controller/dwc/pcie-nxp-s32g.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vb6pcyaue6pqpx626ytfr2aif4luypopywqoazjsvy4crh6zic@gfv75ar7musy>
Date: Tue, 2 Dec 2025 15:23:11 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Vincent Guittot <vincent.guittot@...aro.org>
Cc: Randy Dunlap <rdunlap@...radead.org>, 
	Stephen Rothwell <sfr@...b.auug.org.au>, Linux Next Mailing List <linux-next@...r.kernel.org>, 
	linux-pci@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>, NXP S32 Linux Team <s32@....com>, 
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, linux-arm-kernel@...ts.infradead.org, 
	Bjorn Helgaas <helgaas@...nel.org>
Subject: Re: linux-next: Tree for Nov 28
 (drivers/pci/controller/dwc/pcie-nxp-s32g.o)

On Tue, Dec 02, 2025 at 09:54:24AM +0100, Vincent Guittot wrote:
> On Tue, 2 Dec 2025 at 05:24, Manivannan Sadhasivam <mani@...nel.org> wrote:
> >
> > + Vincent
> 
> Thanks for looping me in.
> >
> > On Sat, Nov 29, 2025 at 07:00:04PM -0800, Randy Dunlap wrote:
> > >
> > >
> > > On 11/27/25 9:29 PM, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > Changes since 20251127:
> > > >
> > >
> > > on i386 (allmodconfig):
> > >
> > > WARNING: modpost: vmlinux: section mismatch in reference: s32g_init_pcie_controller+0x2b (section: .text) -> memblock_start_of_DRAM (section: .init.text)
> 
> Are there details to reproduce the warning ? I don't have such warning
> when compiling allmodconfig locally
> 
> s32 pcie can only be built in but I may have to use
> builtin_platform_driver_probe() instead of builtin_platform_driver()
> 

The is due to calling a function belonging to the __init section from non-init
function. Ideally, functions prefixed with __init like memblock_start_of_DRAM()
should be called from the module init functions.

One way to fix would be to call memblock_start_of_DRAM() in probe(), and
annotate probe() with __init. Since there is no remove, you could use
builtin_platform_driver_probe().

This also makes me wonder if we really should be using memblock_start_of_DRAM()
in the driver. I know that this was suggested to you during reviews, but I would
prefer to avoid it, especially due to this being the __init function.

- Mani

-- 
மணிவண்ணன் சதாசிவம்