linux-kernel - Re: [PATCH] staging: vc04_services: vchiq_bus: Check return value of of_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aS684lo6j3ldvrPn@stanley.mountain>
Date: Tue, 2 Dec 2025 13:18:10 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vc04_services: vchiq_bus: Check return value of
 of_dma_configure()

You're not working against the latest tree so this doesn't apply.

On Tue, Dec 02, 2025 at 05:52:52PM +0800, Haotian Zhang wrote:
> vchiq_device_register() ignores the return value of of_dma_configure(),
> which may return -EPROBE_DEFER when the IOMMU is not ready or other error
> codes. This allows device registration to proceed with incomplete DMA
> configuration.
> 

If of_dma_configure() returns -EPROBE_DEFER then this will just fail and
that's not really any better than the existing behavior...

regards,
dan carpenter

> Check of_dma_configure() return value and fail device registration
> on error.
> 
> Fixes: 027e5703de6b ("staging: vc04_services: vchiq_arm: Add new bus type and device type")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>