linux-kernel - Re: [PATCH 4/6] sched/fair: Rename avg_vruntime() to cfs_avg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251202102435.GA2556898@noisy.programming.kicks-ass.net>
Date: Tue, 2 Dec 2025 11:24:35 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Juri Lelli <juri.lelli@...hat.com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Valentin Schneider <vschneid@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Shrikanth Hegde <sshegde@...ux.ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 4/6] sched/fair: Rename avg_vruntime() to
 cfs_avg_vruntime()

On Mon, Dec 01, 2025 at 07:46:45AM +0100, Ingo Molnar wrote:
> Since the unit of the ->avg_vruntime field isn't actually
> the same thing as the avg_vruntime() result, reduce confusion
> and rename the latter to the common cfs_*() nomenclature of
> visible global functions of the fair scheduler.

But you're going to rename both those fields into sum_weight and
sum_w_vruntime freeing up the avg_vruntime name and clearing up the
above confusion.

So why then still rename the thing? The result of the function really is
the (weighted) average of the vruntime, so the naming isn't confusing
or bad (unlike the variables it uses, which are pretty badly named).