linux-kernel - Re: [PATCH net-next v2 1/1] net: mdio: reset PHY before attempting to access ID register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79c050e9-83e7-4cc5-979e-457f098024bf@lunn.ch>
Date: Tue, 2 Dec 2025 14:46:42 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Buday Csaba <buday.csaba@...lan.hu>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: mdio: reset PHY before attempting
 to access ID register

> @@ -13,9 +13,12 @@
>  #include <linux/phy.h>
>  #include <linux/pse-pd/pse.h>
>  
> +#include "../phy/mdio-private.h"

Relative imports are generally not allowed. It sometimes suggests
layering violations.

I'm not convinced the complexity and ugliness of partially registering
a device in order to be able to reset it, is worth the effort when we
have a simpler solution of just using the ID values in DT.

Give the merge window, i will mark this as change request for the
moment.

    Andrew

---
pw-bot: cr