linux-kernel - Re: [PATCH] wifi: cfg80211: sme: store capped length in __cfg80211_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3204ebc0-4432-467c-81fe-9f09427b1671@web.de>
Date: Wed, 3 Dec 2025 18:57:42 +0100
From: Rolf Reintjes <rolf.reintjes@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>, qgeniecore@...lcomm.com
Cc: Johannes Berg <johannes@...solutions.net>,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: sme: store capped length in
 __cfg80211_connect_result()

Hello Dan,

Am 03.12.2025 um 12:14 schrieb Dan Carpenter:
> The QGenie AI code review tool

Could you tell us more about this tool? Is there a web page of this 
tool, how do you use this tool?

I found https://qgenie.ai/ but this is not a code review tool.

Rolf

> says we should store the capped length to
> wdev->u.client.ssid_len.  The AI is correct.
> 
> Fixes: 62b635dcd69c ("wifi: cfg80211: sme: cap SSID length in __cfg80211_connect_result()")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   net/wireless/sme.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 3a028ff287fb..4e629ca305bc 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -910,7 +910,7 @@ void __cfg80211_connect_result(struct net_device *dev,
>   
>   			ssid_len = min(ssid->datalen, IEEE80211_MAX_SSID_LEN);
>   			memcpy(wdev->u.client.ssid, ssid->data, ssid_len);
> -			wdev->u.client.ssid_len = ssid->datalen;
> +			wdev->u.client.ssid_len = ssid_len;
>   			break;
>   		}
>   		rcu_read_unlock();