linux-kernel - [PATCH 0/3] ASoC: amd/sdw: Fix confusing cleanup.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251203-asoc-wrong-cleanup-h-continued-v1-0-5142be4874fb@oss.qualcomm.com>
Date: Wed, 03 Dec 2025 17:12:37 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Maciej Strozek <mstrozek@...nsource.cirrus.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com,
        Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Subject: [PATCH 0/3] ASoC: amd/sdw: Fix confusing cleanup.h

cleanup.h coding style asks to avoid having constructors with redundant
values (= NULL). On purpose, because it is just not making the code
simpler. The constructor should be meaningful not just NULL.

If you do not agree in declaration-in-place-of-use (fair!), then do not
use cleanup.h. If you want to use cleanup.h, then please read cleanup.h
before.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (3):
      ASoC: amd: acp-sdw-legacy: Fix confusing cleanup.h syntax
      ASoC: amd: acp-sdw-sof: Fix confusing cleanup.h syntax
      ASoC: SDCA: functions: Fix confusing cleanup.h syntax

 sound/soc/amd/acp/acp-sdw-legacy-mach.c |  8 ++++----
 sound/soc/amd/acp/acp-sdw-sof-mach.c    |  8 ++++----
 sound/soc/sdca/sdca_functions.c         | 28 ++++++++++++++--------------
 3 files changed, 22 insertions(+), 22 deletions(-)
---
base-commit: 32ed136b4e871f08398f342aa92feffed020839b
change-id: 20251203-asoc-wrong-cleanup-h-continued-6e3d27d097df

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>