linux-kernel - Re: [PATCH iwl-next 1/5] libeth: pass Rx queue index to PP when creating a fill queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c1b214f-b016-45dd-b9a4-7d553967d950@intel.com>
Date: Wed, 3 Dec 2025 09:44:53 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jacob Keller
	<jacob.e.keller@...el.com>, Aleksandr Loktionov
	<aleksandr.loktionov@...el.com>, <nxne.cnse.osdt.itp.upstreaming@...el.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH iwl-next 1/5] libeth: pass Rx queue index to PP when
 creating a fill queue



On 11/25/2025 9:35 AM, Alexander Lobakin wrote:
> Since recently, page_pool_create() accepts optional stack index of
> the Rx queue which the pool will be created for. It can then be
> used on control path for stuff like memory providers.
> Add the same field to libeth_fq and pass the index from all the
> drivers using libeth for managing Rx to simplify implementing MP
> support later.
> idpf has one libeth_fq per buffer/fill queue and each Rx queue has
> two fill queues, but since fill queues can never be shared, we can
> store the corresponding Rx queue index there during the
> initialization to pass it to libeth.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> ---
>   drivers/net/ethernet/intel/idpf/idpf_txrx.h |  2 ++
>   include/net/libeth/rx.h                     |  2 ++
>   drivers/net/ethernet/intel/iavf/iavf_txrx.c |  1 +
>   drivers/net/ethernet/intel/ice/ice_base.c   |  2 ++
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c | 13 +++++++++++++
>   drivers/net/ethernet/intel/libeth/rx.c      |  1 +
>   6 files changed, 21 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> index 75b977094741..1f368c4e0a76 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
> @@ -744,6 +744,7 @@ libeth_cacheline_set_assert(struct idpf_tx_queue, 64,
>    * @q_id: Queue id
>    * @size: Length of descriptor ring in bytes
>    * @dma: Physical address of ring
> + * @rxq_idx: stack index of the corresponding Rx queue
>    * @q_vector: Backreference to associated vector
>    * @rx_buffer_low_watermark: RX buffer low watermark
>    * @rx_hbuf_size: Header buffer size
> @@ -788,6 +789,7 @@ struct idpf_buf_queue {
>   	dma_addr_t dma;
>   
>   	struct idpf_q_vector *q_vector;
> +	u16 rxq_ixd;

I believe this is supposed to be rxq_idx?

Thanks,
Tony

>   	u16 rx_buffer_low_watermark;
>   	u16 rx_hbuf_size;