linux-kernel - Re: [tip: objtool/urgent] objtool: Consolidate annotation macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bp6dxqsfa66txee3b7kzqgj2hgzow6ukvffczn2fz43kn53prv@2zlw65irjsc6>
Date: Wed, 3 Dec 2025 09:51:42 -0800
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-tip-commits@...r.kernel.org, x86@...nel.org
Subject: Re: [tip: objtool/urgent] objtool: Consolidate annotation macros

On Wed, Dec 03, 2025 at 09:44:45AM -0800, Linus Torvalds wrote:
> On Wed, 3 Dec 2025 at 09:21, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> >
> > It *feels* like this should just all be
> >
> >         911: .pushsection .discard.annotate_insn ; .long 911b - .; .long 1; .popsection
> >         jmp __x86_return_thunk
> >
> > instead.
> 
> Actually, I think it should just be
> 
>   911: jmp __x86_return_thunk
>   .pushsection .discard.annotate_insn ; .long 911b - . , 1; .popsection
> 
> but again: it's entirely possible that there's something I am missing.

Indeed, we can combine the longs (though see my other email for the
explanation about the mergeable thing).

-- 
Josh