linux-kernel - Re: [PATCH net-next] gve: Move gve_init_clock to after AQ CONFIGURE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTCGK4DtwVkY4FkI@horms.kernel.org>
Date: Wed, 3 Dec 2025 18:49:15 +0000
From: Simon Horman <horms@...nel.org>
To: Harshitha Ramamurthy <hramamurthy@...gle.com>
Cc: netdev@...r.kernel.org, joshwash@...gle.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, richardcochran@...il.com, willemb@...gle.com,
	pkaligineedi@...gle.com, thostet@...gle.com,
	linux-kernel@...r.kernel.org, Ankit Garg <nktgrg@...gle.com>
Subject: Re: [PATCH net-next] gve: Move gve_init_clock to after AQ
 CONFIGURE_DEVICE_RESOURCES call

On Tue, Dec 02, 2025 at 08:02:07PM +0000, Harshitha Ramamurthy wrote:
> From: Tim Hostetler <thostet@...gle.com>
> 
> commit 46e7860ef941 ("gve: Move ptp_schedule_worker to gve_init_clock")
> moved the first invocation of the AQ command REPORT_NIC_TIMESTAMP to
> gve_probe(). However, gve_init_clock() invoking REPORT_NIC_TIMESTAMP is
> not valid until after gve_probe() invokes the AQ command
> CONFIGURE_DEVICE_RESOURCES.
> 
> Failure to do so results in the following error:
> 
> gve 0000:00:07.0: failed to read NIC clock -11
> 
> This was missed earlier because the driver under test was loaded at
> runtime instead of boot-time. The boot-time driver had already
> initialized the device, causing the runtime driver to successfully call
> gve_init_clock() incorrectly.
> 
> Fixes: 46e7860ef941 ("gve: Move ptp_schedule_worker to gve_init_clock")
> Reviewed-by: Ankit Garg <nktgrg@...gle.com>
> Signed-off-by: Tim Hostetler <thostet@...gle.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>