linux-kernel - Re: [PATCH v3] mcb: Add missing modpost build support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251203202721.GA3060476@ax162>
Date: Wed, 3 Dec 2025 13:27:21 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>,
	andy@...nel.org, krzk@...nel.org, linus.walleij@...aro.org,
	nsc@...nel.org, bleung@...omium.org,
	heikki.krogerus@...ux.intel.com, abhishekpandit@...omium.org,
	masahiroy@...nel.org, legion@...nel.org, hughd@...gle.com,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
Subject: Re: [PATCH v3] mcb: Add missing modpost build support

On Wed, Dec 03, 2025 at 09:07:02AM +0100, Greg KH wrote:
> On Tue, Dec 02, 2025 at 01:34:21PM -0700, Nathan Chancellor wrote:
> > On Tue, Dec 02, 2025 at 09:42:00AM +0100, Jose Javier Rodriguez Barbarin wrote:
> > > mcb bus is not prepared to autoload client drivers with the data defined on
> > > the drivers' MODULE_DEVICE_TABLE. modpost cannot access to mcb_table_id
> > > inside MODULE_DEVICE_TABLE so the data declared inside is ignored.
> > > 
> > > Add modpost build support for accessing to the mcb_table_id coded on device
> > > drivers' MODULE_DEVICE_TABLE.
> > > 
> > > Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus")
> > > Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
> > > Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> > > ---
> > 
> > Acked-by: Nathan Chancellor <nathan@...nel.org>
> > 
> > We should be able to get this to Linus by 6.19-rc1.
> 
> Why?  What's the rush?

I was going off of Andy's previous comments about getting this into a
6.19-rc release to allow Jose to send the follow up changes for removing
MODULE_ALIAS from the drivers that use mcb_device_id, which are spread
out across the tree.

  https://lore.kernel.org/CAHp75VfhM5GuYY1qUKgBhePDo4oe5k3K1ZDTPbYJNr5NtjVVfQ@mail.gmail.com/
  https://lore.kernel.org/aS3YUYtrEn39lUPl@smile.fi.intel.com/

That could be -rc2 or -rc3 obviously but -rc1 is objectively the most
compatible base for all maintainer trees.

> It should have been in -next already to get into -rc1.

This seems like a low risk change, maybe even a borderline fix (and it
would still be in -next before it went to Linus). I do not have to push
it that quickly though, I have no strong opinion on the priority of this
change. Another option would be a shared branch after -rc1 is out that
other trees could pull in so that those changes could go into 6.20 and
get proper -next soak time.

Cheers,
Nathan