[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMRc=Mce0V0agv--=Tn0efG7+ehDM4H0Ks1dQ5h+X3dOxYp-TQ@mail.gmail.com>
Date: Wed, 3 Dec 2025 21:34:38 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Ali Tariq <alitariq45892@...il.com>
Cc: kernel@...il.dk, hal.feng@...rfivetech.com, linus.walleij@...aro.org,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
Emil Renner Berthing <emil.renner.berthing@...onical.com>
Subject: Re: [PATCH v3] pinctrl: starfive: use dynamic GPIO base allocation
On Sun, Oct 26, 2025 at 12:44 PM Ali Tariq <alitariq45892@...il.com> wrote:
>
> The JH7110 pinctrl driver currently sets a static GPIO base number from
> platform data:
>
> sfp->gc.base = info->gc_base;
>
> Static base assignment is deprecated and results in the following warning:
>
> gpio gpiochip0: Static allocation of GPIO base is deprecated,
> use dynamic allocation.
>
> Set `sfp->gc.base = -1` to let the GPIO core dynamically allocate
> the base number. This removes the warning and aligns the driver
> with current GPIO guidelines.
>
> Since the GPIO base is now allocated dynamically, remove `gc_base` field in
> `struct jh7110_pinctrl_soc_info` and the associated `JH7110_SYS_GC_BASE`
> and `JH7110_AON_GC_BASE` constants as they are no longer used anywhere
> in the driver.
>
> Tested on VisionFive 2 (JH7110 SoC).
>
> Signed-off-by: Ali Tariq <alitariq45892@...il.com>
> Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> ---
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
Powered by blists - more mailing lists