linux-kernel - Re: [PATCH v2] i2c: spacemit: fix detect issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rha5zun6qxzpbi5arzsjaywgzzardvsrjyibaw42yqpom6nx47@wmusvc7bqhl5>
Date: Wed, 3 Dec 2025 21:46:02 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Cc: Yixun Lan <dlan@...too.org>, Alex Elder <elder@...cstar.com>, 
	Michael Opdenacker <michael.opdenacker@...tcommit.com>, Aurelien Jarno <aurelien@...el32.net>, 
	Troy Mitchell <troymitchell988@...il.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev
Subject: Re: [PATCH v2] i2c: spacemit: fix detect issue

Hi Troy,

On Thu, Nov 13, 2025 at 09:21:50PM +0800, Troy Mitchell wrote:
> This commit addresses two issues causing i2c detect to fail.
> 
> The identified issues are:
> 
> 1. Incorrect error handling for BED (Bus Error No ACK/NAK):
>    Before this commit, Both ALD (Arbitration Loss Detected) and
>    BED returned -EAGAIN.
> 2. Missing interrupt status clear after initialization in xfer():
>    On the K1 SoC, simply fixing the first issue changed the error
>    from -EAGAIN to -ETIMEOUT. Through tracing, it was determined that
>    this is likely due to MSD (Master Stop Detected) latency issues.
> 
>    That means the MSD bit in the ISR may still be set on the next transfer.
>    As a result, the controller won't work — we can see from the scope that
>    it doesn't issue any signal.
>    (This only occurs during rapid consecutive I2C transfers.
>    That explains why the issue only shows up with i2cdetect.)
> 
> With these two fixes, i2c device detection now functions correctly on the K1 SoC.
> 
> Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Tested-by: Aurelien Jarno <aurelien@...el32.net>
> Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>

merged to i2c/i2c-host.

Thanks,
Andi