linux-kernel - Re: [PATCH v2 4/8] drm/xe: Use dma_fence_check_and_signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTCn_1VHOOkvhxpS@intel.com>
Date: Wed, 3 Dec 2025 16:13:35 -0500
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Matthew Brost <matthew.brost@...el.com>
CC: Andi Shyti <andi.shyti@...nel.org>, Philipp Stanner <phasta@...nel.org>,
	Sumit Semwal <sumit.semwal@...aro.org>, Gustavo Padovan
	<gustavo@...ovan.org>, Christian König
	<christian.koenig@....com>, Felix Kuehling <Felix.Kuehling@....com>, "Alex
 Deucher" <alexander.deucher@....com>, David Airlie <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>, Jani Nikula <jani.nikula@...ux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin
	<tursulin@...ulin.net>, Huang Rui <ray.huang@....com>, Matthew Auld
	<matthew.auld@...el.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, Lucas De Marchi
	<lucas.demarchi@...el.com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, <linux-media@...r.kernel.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<amd-gfx@...ts.freedesktop.org>, <intel-gfx@...ts.freedesktop.org>,
	<intel-xe@...ts.freedesktop.org>
Subject: Re: [PATCH v2 4/8] drm/xe: Use dma_fence_check_and_signal_locked()

On Tue, Dec 02, 2025 at 01:04:24PM -0800, Matthew Brost wrote:
> On Tue, Dec 02, 2025 at 09:47:39PM +0100, Andi Shyti wrote:
> > Hi Matt,
> > 
> > > > @@ -93,9 +92,8 @@ void xe_hw_fence_irq_finish(struct xe_hw_fence_irq *irq)
> > > >  		spin_lock_irqsave(&irq->lock, flags);
> > > >  		list_for_each_entry_safe(fence, next, &irq->pending, irq_link) {
> > > >  			list_del_init(&fence->irq_link);
> > > > -			err = dma_fence_signal_locked(&fence->dma);
> > > > +			XE_WARN_ON(dma_fence_check_and_signal_locked(&fence->dma));
> > > 
> > > I think XE_WARN_ON can compile out in certain builds. Best to leave warn on logic as is.
> > 
> > I don't think XE_WARN_ON compiles out. It should always evaluate
> > the content, then, depending on the build, it prints debug logs.
> 
> Ah, ok. I thought XE_WARN_ON was tied to a Kconfig to compile out or
> WARN_ON (this is what XE_WARN_ON resolves) compiled out in some kernel
> builds. Upon more looking, I guess neither of these is the case.
> 
> So I guess this patch is actually:
> Reviewed-by: Matthew Brost <matthew.brost@...el.com>

and

Acked-by: Rodrigo Vivi <rodrigo.vivi@...el.com>

if needed to merge through any other tree...

> 
> Sorry for the noise. Side note, we should probably just XE_WARN_ON too
> since this is just WARN_ON.
> 
> Matt
> 
> > 
> > Andi