linux-kernel - Re: [PATCH RFC/RFT net-next v2 1/5] net: dsa: deny bridge VLAN with existing 8021q upper on any port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18bccfd5-ad55-45e8-8d9f-7f3ed2aac21e@meta.com>
Date: Tue, 2 Dec 2025 19:36:07 -0500
From: Chris Mason <clm@...a.com>
To: Simon Horman <horms@...nel.org>
Cc: Jonas Gorski <jonas.gorski@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH RFC/RFT net-next v2 1/5] net: dsa: deny bridge VLAN with
 existing 8021q upper on any port

On 12/2/25 11:16 AM, Simon Horman wrote:
> On Mon, Dec 01, 2025 at 02:48:48PM -0800, Chris Mason wrote:
>> On Mon, 1 Dec 2025 20:52:34 +0100 Jonas Gorski <jonas.gorski@...il.com> wrote:

[ ... ]

>>
>> I reproduced this false positive here, thanks for the explanation.  This is an
>> example of a class of review mistakes I've wanted to fix, so I used it to
>> improve the prompts around NULL pointers that are protected via other checks.
>>
>> I'll test this on some more commits and push it out.
> 
> Thanks for following-up on this Chris.
> 
> I guess everyone has their own opinion on AI.
> And, in a similar vein, many have opinions on the review-prompts.
> But, FTR, I've been impressed by the output I've seen,
> having used them for a few weeks now. And I look forward
> to that improving further.
> 

Thanks, I really appreciate everyone being willing to experiment with
the reviews (and huge thanks to Jakub for wiring this up).  I'll try to
stay on top of the false positives, but please also let me know if I'm
missing classes of bugs.

I think Jonas's other_dp->user check is really at the limit of claude's
ability to reason about the code in a generic way, and I'm still trying
to get it to process this patch consistently.

If all else fails we can fix some of these with more networking specific
knowledge, but I'm trying to avoid whack-a-mole.

-chris