linux-kernel - Re: [PATCH] pinctrl: single: Fix incorrect type for error return variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jLnH-ZT+9YMxqZ=TV=0fatXSRcFkJMk-snEuRSMLdfD6PQ@mail.gmail.com>
Date: Thu, 4 Dec 2025 00:20:14 +0100
From: Linus Walleij <linusw@...nel.org>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: tony@...mide.com, haojian.zhuang@...aro.org, linus.walleij@...aro.org, 
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: single: Fix incorrect type for error return variable

On Wed, Dec 3, 2025 at 7:14 AM Haotian Zhang <vulab@...as.ac.cn> wrote:

> pcs_pinconf_get() and pcs_pinconf_set() declare ret as unsigned int,
> but assign it the return values of pcs_get_function() that may return
> negative error codes. This causes negative error codes to be
> converted to large positive values.
>
> Change ret from unsigned int to int in both functions.
>
> Fixes: 9dddb4df90d1 ("pinctrl: single: support generic pinconf")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Patch applied.
Thanks Haotian!

Yours,
Linus Walleij