linux-kernel - [PATCH] adfs: Fix incorrect unsigned return type in adfs_f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251203065120.652-1-vulab@iscas.ac.cn>
Date: Wed,  3 Dec 2025 14:51:20 +0800
From: Haotian Zhang <vulab@...as.ac.cn>
To: rmk+kernel@...linux.org.uk
Cc: viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org,
	Haotian Zhang <vulab@...as.ac.cn>
Subject: [PATCH] adfs: Fix incorrect unsigned return type in adfs_f_getnext()

adfs_f_getnext() stores the return value of __adfs_dir_get() into an
unsigned int. Since __adfs_dir_get() may return negative error codes
such as -ENOENT, these values are converted into large positive numbers.

Change the return variable to type int to correctly preserve and return
negative error codes.

Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
---
 fs/adfs/dir_f.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
index 05e963402e25..81dedb796b56 100644
--- a/fs/adfs/dir_f.c
+++ b/fs/adfs/dir_f.c
@@ -242,7 +242,7 @@ adfs_f_setpos(struct adfs_dir *dir, unsigned int fpos)
 static int
 adfs_f_getnext(struct adfs_dir *dir, struct object_info *obj)
 {
-	unsigned int ret;
+	int ret;
 
 	ret = __adfs_dir_get(dir, dir->pos, obj);
 	if (ret == 0)
-- 
2.50.1.windows.1