linux-kernel - Re: [PATCH] staging: rtl8723bs: clean up comments in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025120312-kitten-carnival-7325@gregkh>
Date: Wed, 3 Dec 2025 08:20:26 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: duccdev <duccybaka@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: clean up comments in rtw_ap.c

On Wed, Dec 03, 2025 at 04:32:29AM +0300, duccdev wrote:
> Fixed 4 multi-line comments to follow kernel coding style.
> Improved clarity and fixed overly long lines reported by checkpatch.
> 
> Signed-off-by: duccdev <duccybaka@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 0908f2234f67..210fa5388a01 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -391,7 +391,7 @@ void update_bmc_sta(struct adapter *padapter)
>  
>  		memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats));
>  
> -		/* psta->dot118021XPrivacy = _NO_PRIVACY_;//!!! remove it, because it has been set before this. */
> +		/* psta->dot118021XPrivacy is already set earlier; do not reset it here. */
>  
>  		/* prepare for add_RATid */
>  		supportRateNum = rtw_get_rateset_len((u8 *)&pcur_network->supported_rates);
> @@ -658,9 +658,11 @@ void start_bss_network(struct adapter *padapter)
>  	cur_bwmode = CHANNEL_WIDTH_20;
>  	cur_ch_offset = HAL_PRIME_CHNL_OFFSET_DONT_CARE;
>  
> -	/* check if there is wps ie, */
> -	/* if there is wpsie in beacon, the hostapd will update beacon twice when stating hostapd, */
> -	/* and at first time the security ie (RSN/WPA IE) will not include in beacon. */
> +	/*
> +	 * Check for a WPS IE. When WPS information is present in the beacon,
> +	 * hostapd updates the beacon twice during startup. On the first update,
> +	 * the security IE (RSN/WPA) may not yet be included.
> +	 */
>  	if (!rtw_get_wps_ie(pnetwork->ies + _FIXED_IE_LENGTH_,
>  			    pnetwork->ie_length - _FIXED_IE_LENGTH_, NULL, NULL))
>  		pmlmeext->bstart_bss = true;
> @@ -841,8 +843,16 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  	memcpy(pbss_network->mac_address, myid(&padapter->eeprompriv), ETH_ALEN);
>  
>  	/* beacon interval */
> -	p = rtw_get_beacon_interval_from_ie(ie);/* ie + 8;	8: TimeStamp, 2: Beacon Interval 2:Capability */
> -	/* pbss_network->configuration.beacon_period = le16_to_cpu(*(unsigned short*)p); */
> +	/*
> +	 * In the beacon IE, the layout starts with:
> +	 *   - 8 bytes: timestamp
> +	 *   - 2 bytes: beacon interval
> +	 *   - 2 bytes: capability info
> +	 * rtw_get_beacon_interval_from_ie() extracts the beacon interval field.
> +	 */
> +	p = rtw_get_beacon_interval_from_ie(ie);
> +
> +	/* pbss_network->configuration.beacon_period = le16_to_cpu(*(unsigned short *)p); */
>  	pbss_network->configuration.beacon_period = get_unaligned_le16(p);
>  
>  	/* capability */
> @@ -1147,7 +1157,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  	/*  update AP's sta info */
>  	update_ap_info(padapter, psta);
>  
> -	psta->state |= WIFI_AP_STATE;		/* Aries, add, fix bug of flush_cam_entry at STOP AP mode , 0724 */
> +	/* Aries, add, fix bug of flush_cam_entry at STOP AP mode, 0724 */
> +	psta->state |= WIFI_AP_STATE;
>  	rtw_indicate_connect(padapter);
>  
>  	pmlmepriv->cur_network.join_res = true;/* for check if already set beacon */
> -- 
> 2.52.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot